While there is currently validation of the token to the channel, the specific endpoint used for invitations requires the 'admin' scope for the owner of the token, without such the lack of error error (#2627054: Notice: Undefined index: error in Drupal\slack_invite\Form\SlackInviteForm->submitForm()) will occur.

Will look into a patch this evening.

CommentFileSizeAuthor
#3 admin_scope-2627060-3.patch911 bytesdeciphered
#3 interdiff.txt828 bytesdeciphered
#2 admin_scope-2627060-2.patch917 bytesdeciphered

Comments

Deciphered created an issue. See original summary.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review
StatusFileSize
new admin_scope-2627060-2.patch917 bytes
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new interdiff.txt828 bytes
new admin_scope-2627060-3.patch911 bytes

Fixed issue with original patch.

  • 721183f committed on 8.x-1.x 
    Issue #2627060 by Deciphered: Validate token scope - use Exception...
  • Deciphered authored b67ceed on 8.x-1.x
    Issue #2627060 by Deciphered: Validate token scope
btmash’s picture

btmash commented
Status: Needs review » Fixed

I liked your patch and how you found the admin scope and committed your patch. I made some additional changes on top of it so your setErrorByName() would now throw an exception and getMessage() instead of the hardcoded message.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.