Perhaps I'm wrong but for me taxonomy filter should apply to nodes last revision. In current drupal version (6.2) filter is built using term_node.nid matching with node.nid and it should be term_node.vid with node.vid :

line 194 should look like :
        $join .= "INNER JOIN {term_node} $table ON n.vid = $table.vid ";

Files: 
CommentFileSizeAuthor
#26 show_last_version_of_node-262498-26.patch540 bytesThomas_Zahreddin
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es).
[ View ]
#9 262498-remove-taxonomy-content-filter.patch697 bytesDjebbZ
PASSED: [[SimpleTest]]: [MySQL] 36,597 pass(es).
[ View ]
#4 node.admin_.inc_.patch483 bytesEugenMayer
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch node.admin_.inc__0.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Comments

nonsie’s picture

Status:Needs review» Needs work

Still present in 6.12

Gerhard Killesreiter’s picture

Version:6.2» 7.x-dev
Status:Needs work» Active

no patch, but still exists.

EugenMayer’s picture

Version:7.x-dev» 6.2
Status:Active» Needs work

bump up, still present in 6.14

EugenMayer’s picture

StatusFileSize
new483 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch node.admin_.inc__0.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Patch attached. Killes found / fixed it

Gerhard Killesreiter’s picture

Version:6.2» 6.x-dev
Status:Needs work» Reviewed & tested by the community

Let's get that into 6.15

Gábor Hojtsy’s picture

Version:6.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Bugs are first fixed on Drupal 7 and then backported to Drupal 6 to ensure we do not introduce regressions.

xjm’s picture

Version:7.x-dev» 8.x-dev
Status:Patch (to be ported)» Needs work
Issue tags:+needs backport to D6, +Novice, +needs backport to D7
EugenMayer’s picture

i would schedule this complicated fix and review for around the year 2015, or even slighly later. This is also a little to bloody-edge for 8.x

DjebbZ’s picture

StatusFileSize
new697 bytes
PASSED: [[SimpleTest]]: [MySQL] 36,597 pass(es).
[ View ]

In D8, one can't filter nodes tagged with a certain tag. The menu callback function for the page admin/content does not propose a way to filter nodes by term. The only filters proposed by node_filters() are the status, the node type and optionally the language. The function is the same in D7. But in D6 we can filter by terms (seen in code and in the UI). What do we do for D8 ? Do we allow the possibility to filter by term ? Or do we remove the legacy code ?
Here's a patch for the second option (the most easy one), even if I would prefer the first option. I don't know why it was removed.

DjebbZ’s picture

Status:Needs work» Needs review

Forgot to change status.

agentrickard’s picture

Very odd. The patch addresses cruft that was left in after an existing feature was removed.

My opinion is that we should commit the patch and then work on fixing the issue by providing better content admin tools in core.

DjebbZ’s picture

I want to agree with you here. What about D7 and D6 ? I would say backport the patch to D7 (should be easy).

dawehner’s picture

And for d6 the patch from eugenmayer should be used, as it's a bug there.

agentrickard’s picture

D7, yes. But D6 is supposed to allow taxonomy filtering.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

We can't write a patch which tests a non existing feature, or?

The code which removes it looks fine!

xjm’s picture

#15: Yeah, I agree there's no test to write here.

Dries’s picture

Version:8.x-dev» 7.x-dev

Committed to 8.x. Moving to 7.x.

dawehner’s picture

Status:Reviewed & tested by the community» Needs review

Let's see what the testbot thinks, if it works fine, it's RTBC.

xjm’s picture

xjm’s picture

Status:Needs review» Reviewed & tested by the community

So #9 is RTBC for D7.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 7.x too.

Marking this issue fixed, though it sounds like we need a follow-up to replace this functionality in D8.

EugenMayer’s picture

Status:Fixed» Reviewed & tested by the community

well, isnt that fixed when its also applied to D6?

xjm’s picture

Status:Reviewed & tested by the community» Patch (to be ported)

Needs a current D6 port. :)

xjm’s picture

Version:7.x-dev» 6.x-dev

durr

Thomas_Zahreddin’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new540 bytes
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es).
[ View ]

tried with #0 but as patch ;-) for D 6.x (dev)

(and meanwhile some people agree it's better to speak of versions if you mean versions).

Niklas Fiekas’s picture

Status:Needs review» Reviewed & tested by the community

Yep, that looks good and fixes the issue for me.

Kristen Pol’s picture

I applied patch #26 successfully as well.

Cottser’s picture

Status:Fixed» Closed (fixed)
Issue tags:-needs backport to D6, -Novice, -needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.