I'm curious about why a dependency on the Elements module was added in the latest release: http://cgit.drupalcode.org/openlayers/commit/?id=e0495a0a1640002df760db9...

Can you point out specifically what part of the openlayers_library module depends on Elements?

CommentFileSizeAuthor
#2 openlayers_examples_elements_dependency-2620098-2.patch951 bytesm.stenta
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m.stenta created an issue. See original summary.

m.stenta’s picture

m.stenta
he/him
Primary language English
CreditAttribution: m.stenta commented
Status: Active » Needs review
FileSize
openlayers_examples_elements_dependency-2620098-2.patch951 bytes

I think this dependency should be in the Openlayers Examples module - not in the Openlayers Library module.

I am not building any maps that require Elements, but I am using Openlayers Library. It should be up to the module creating the maps to declare their dependencies.

Attached is a patch that moves the dependency to the Openlayers Examples module.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol as a volunteer commented
Status: Needs review » Needs work

The module who provides the UI for the components is openlayers_library... so it makes sense to me that the dependency should stay there... unless you have a better way ?

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol as a volunteer commented
Status: Needs work » Closed (won't fix)

After a discussion on hangouts, this ticket can be closed.