...no big issue.
Just 3 single-quoted attributes in the following core template files. I don't know if this is covered by any other issue or the template files are reworked anyway before the release.

  • bartik/templates/field--node--field-tags.html.twig class='field__items'
  • classy/templates/field/field--comment.html.twig class='title comment-form__title'
  • classy/templates/field/field.html.twig class='field__items'
CommentFileSizeAuthor
#6 drupal-correct_attributes_in_core_templates-2618048-6-8.x.0.patch1.74 KBseppelM
#2 correct_HTML_attribute_s__in_core_template_files-2618048-2.patch2.09 KBseppelM

Comments

seppelM created an issue. See original summary.

seppelM’s picture

seppelM commented
StatusFileSize
new correct_HTML_attribute_s__in_core_template_files-2618048-2.patch2.09 KB
seppelM’s picture

seppelM commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: correct_HTML_attribute_s__in_core_template_files-2618048-2.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Title: HTML attribute(s) in core template files » Single quoted HTML attributes in Bartik and Classy template files
Version: 8.0.0-rc4 » 8.0.x-dev
Component: theme system » markup
Issue tags: -html, -bartik theme

@seppelM thanks! Please generate the patch from git, see https://www.drupal.org/node/707484.

seppelM’s picture

seppelM commented
StatusFileSize
new drupal-correct_attributes_in_core_templates-2618048-6-8.x.0.patch1.74 KB

Ok, re-generated the patch

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Looks good, RTBC if green. Can go in after 8.0.0. Thanks @seppelM!

The last submitted patch, 2: correct_HTML_attribute_s__in_core_template_files-2618048-2.patch, failed testing.

  • catch committed fa7a89a on 8.1.x 
    Issue #2618048 by seppelM: Single quoted HTML attributes in Bartik and...

  • catch committed b57a76a on 
    Issue #2618048 by seppelM: Single quoted HTML attributes in Bartik and...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and cherry-picked to 8.0.x, thanks!

In general template changes would be frozen, but this doesn't change the markup as such.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.