Currently, the image widget has the default image set to FID 45. This basically means, that whatever file on your site which has the FID 45 will end up being the default image for the image widget. :-) I'm sure this snuck in accidentally and no one noticed, but it's quite strange and surprising when it comes up.

We should not set a default image for the image widget!

CommentFileSizeAuthor
#3 panopoly_widgets-default-image-2617618-3.patch1.06 KBdsnopek
#2 panopoly_widgets-default-image-2617618-2.patch493 bytesdsnopek

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly_widgets-default-image-2617618-2.patch493 bytes

Here's the patch! Super simple, I just want to test it some more and think about the upgrade path.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_widgets-default-image-2617618-3.patch1.06 KB

I did some testing with this. It looks like an upgrade path will be necessary, otherwise existing sites are stuck with the problem even if new sites are fixed. Here's a new patch for that!

I'll need to make sure that tests pass on Travis before committing.

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/91706376

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Automated tests pass! I'm going to commit this.

  • dsnopek committed 3ce7a2f on 7.x-1.x 
    Update Panopoly Widgets for Issue #2617618 by dsnopek: Don't set default...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.