If you go to /core and run phpunit --testsuite unit it fails because #2603138: CSS/JS asset caching can easily be trashed introduced a test. However the test to fix is LibraryDiscoveryParserTest as this is the test that does not check things correctly.

CommentFileSizeAuthor
#2 2616846-2.patch1.68 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2616846-2.patch1.68 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2616846-2.patch, failed testing.

The last submitted patch, 2: 2616846-2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

The fails have nothing to do with this patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

The fails have nothing to do with this patch.

Status: Needs review » Needs work

The last submitted patch, 2: 2616846-2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

They still have nothing to do with this patch

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yep, testbot is basically broken right now. Already reported in #drupal-testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2616846-2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

DrupalCI hopefully you are fixed.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

For now that seems to be the right fix. On the longrun we should just move the constants to the class, reference the old ones and be happy. This would be a BC compatible fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@dawehner I totally agree that we should deprecate all Global constants throughout the 8.x.x cycle but yeah I just did the quickest thing.

neclimdul’s picture

neclimdul
He/Him
commented

+1 on both accounts, thanks.

  • catch committed 6b96686 on 8.0.x 
    Issue #2616846 by alexpott: PHPUnit is broken again from the command...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 6b96686 on 8.1.x 
    Issue #2616846 by alexpott: PHPUnit is broken again from the command...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.