ViewResultAssertionTrait::assertIdenticalResultsetHelper verbose output tries to print the arguments for the query that was used, but this always shows up empty.

Before

After patch in #2

CommentFileSizeAuthor
#3 query arguments not empty.png57.57 KBlendude
#2 query_argument_verbose_empty-2616412-2.patch822 byteslendude
query arguments empty.png47.69 KBlendude

Comments

Lendude created an issue. See original summary.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
StatusFileSize
new query_argument_verbose_empty-2616412-2.patch822 bytes

And the fix.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue summary: View changes
StatusFileSize
new query arguments not empty.png57.57 KB

And an 'after' screenshot.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +rc eligible

Perfect

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: query_argument_verbose_empty-2616412-2.patch, failed testing.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Reviewed & tested by the community

random test fail, back to RTBC

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

+1 to this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 81bfce5 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed 7960cbc on 8.1.x 
    Issue #2616412 by Lendude: ViewResultAssertionTrait verbose Query...

  • alexpott committed 81bfce5 on 8.0.x 
    Issue #2616412 by Lendude: ViewResultAssertionTrait verbose Query...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.