Problem/Motivation

Postgres testing is failing at the moment, both on PHP5.5 and PHP7, for example: https://www.drupal.org/pift-ci-job/81024

Proposed resolution

The test is only limited the filter of translations to french on admin/config/regional/translate. It should also be limiting to customised translations otherwise the test is dependent on DB ordering.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 2615776-5.patch708 bytesalexpott
#2 2615776-2.patch597 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2615776-2.patch597 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Yep this fixes the fail! See https://dispatcher.drupalci.org/job/default/37054/consoleFull and search for LocalePluralFormatTest

xjm’s picture

xjm
she/her
Primary language English
commented

Should we add an inline comment explaining why it's necessary?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2615776-5.patch708 bytes

Sure why not.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Great! We have documentation and a fix!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 41440c0 on 8.0.x 
    Issue #2615776 by alexpott: LocalePluralFormatTest is failing on...

  • catch committed 41440c0 on 8.1.x 
    Issue #2615776 by alexpott: LocalePluralFormatTest is failing on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.