CommentFileSizeAuthor
#13 Screen Shot 2016-03-09 at 15.15.49.png62.03 KBemma.maria
#12 before-apply-patch-mobile.png35.06 KBSumit kumar
#12 before-apply-patch-desktop.png45.59 KBSumit kumar
#12 after-apply-patch-desktop.png39.5 KBSumit kumar
#12 mobile-after-apply-patch.png60.59 KBSumit kumar
#10 Drupal_core-Vertical_tabs-2614860-10-.patch708 bytessaurabh.dhariwal
#10 before-tab-view.jpg53.49 KBsaurabh.dhariwal
#10 before-desktop-view.jpg56.63 KBsaurabh.dhariwal
#10 after-tab-view.jpg55.32 KBsaurabh.dhariwal
#10 after-desktop-view.jpg54.84 KBsaurabh.dhariwal
#6 Vertical_tabs_has_too_much_left_margin-2614860-6.patch885 bytessaurabh.dhariwal
#4 i2614860-4.patch0 bytesiamDamon
Screen Shot 2015-11-13 at 11.54.32.png47.46 KBiamDamon

Comments

iamDamon created an issue. See original summary.

iamDamon’s picture

iamDamon commented
Assigned: Unassigned » iamDamon
Issue summary: View changes
iamDamon’s picture

iamDamon commented
Title: Vertical-tabs has too much margin + panes & menu don't fit next to each other » Vertical-tabs has too much left margin
iamDamon’s picture

iamDamon commented
Assigned: iamDamon » Unassigned
StatusFileSize
new i2614860-4.patch0 bytes

Fix for margins

wolf_22’s picture

wolf_22 commented

Your patch file is empty... That's a problem.

...but that aside, it's not just the left-margin that's causing problems on that page. It also has a floating / clearing issue with the left-hand context menu, as seen by how its right-border is missing (or visibly concealed) and how that entire section is basically flush against the text in the right-hand side of that page, which is abnormal.

saurabh.dhariwal’s picture

saurabh.dhariwal commented
StatusFileSize
new Vertical_tabs_has_too_much_left_margin-2614860-6.patch885 bytes

Find the attachment of the patch. Removed left margin & fixed alignments for vertical tabs.

Let me know if any query/confusion for the same.

Snehal Brahmbhatt’s picture

Snehal Brahmbhatt commented
Status: Active » Reviewed & tested by the community

The last submitted patch, 4: i2614860-4.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Vertical-tabs has too much left margin » Vertical-tabs have too much left margin
Status: Reviewed & tested by the community » Needs work
Issue tags: +CSS

Before/after screenshots are missing.

More importantly, you can't just change the stable theme AFAIK. Otherwise it's not stable, which is the whole point.

saurabh.dhariwal’s picture

saurabh.dhariwal commented
StatusFileSize
new after-desktop-view.jpg54.84 KB
new after-tab-view.jpg55.32 KB
new before-desktop-view.jpg56.63 KB
new before-tab-view.jpg53.49 KB
new Drupal_core-Vertical_tabs-2614860-10-.patch708 bytes

Removed CSS from Stable theme & added it in Bartik theme.

Please find the attached screenshots for the same.

krina.addweb’s picture

krina.addweb commented
Status: Needs work » Needs review
Sumit kumar’s picture

Sumit kumar commented
StatusFileSize
new mobile-after-apply-patch.png60.59 KB
new after-apply-patch-desktop.png39.5 KB
new before-apply-patch-desktop.png45.59 KB
new before-apply-patch-mobile.png35.06 KB

Patch #10 is working fine

emma.maria’s picture

emma.maria
she/her
commented
Issue summary: View changes
Status: Needs review » Closed (duplicate)
StatusFileSize
new Screen Shot 2016-03-09 at 15.15.49.png62.03 KB

As #2541252: Replace the .region-content ul/ol selector with text-formatted to refactor code + fix visual bugs was committed to 8.0.x and fixed the vertical tabs issue, I am closing this one.

emma.maria’s picture

emma.maria
she/her
commented
Issue summary: View changes

Screenshot of current 8.0.x