If a string has multiple matches in the glossary, they are not shown in the Firefox extension! Only the first one is.
That's annoying.

Comments

Artusamak created an issue. See original summary.

izus’s picture

Status: Active » Needs review
StatusFileSize
new12.23 KB

Hello,
Here is a patch that deletes some old files that were not present in the initial patch.
it also fixes the issue described here.
i will upload the generated .xpi to ease testings

Thanks

izus’s picture

StatusFileSize
new30.13 KB

To test, please rename the file deleting the .txt extension :)
Edit:
rename the file to @l10nfirefox-0.0.2.xpi

artusamak’s picture

Status: Needs review » Reviewed & tested by the community

It works like a charm!
Thank you.

SebCorbin’s picture

Status: Reviewed & tested by the community » Fixed

Moved to site

izus’s picture

Hi,
noticed that the patch in #2 is not yet merged in the repository
++

SebCorbin’s picture

Status: Fixed » Needs work

Unfortunately it doesn't apply, you need to do git diff --binary

$ git apply l10n_glossary_tooltip-show_multiple_matches-2614728-2.patch
l10n_glossary_tooltip-show_multiple_matches-2614728-2.patch:182: trailing whitespace.

error: cannot apply binary patch to 'l10n_firefox/@l10nfirefox-0.0.2.xpi' without full index line
error: l10n_firefox/@l10nfirefox-0.0.2.xpi: patch does not apply
izus’s picture

Status: Needs work » Needs review
StatusFileSize
new50.36 KB

Here it is :)

SebCorbin’s picture

Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.