Started working on cleaning up the codebase so that coding standards are respected.

CommentFileSizeAuthor
#3 2614516_3.patch22.13 KBmile23

Comments

Mixologic created an issue. See original summary.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Might work on this as a first step before any refactoring.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Active » Needs review
StatusFileSize
new 2614516_3.patch22.13 KB

Some work on making the DrupalCI code pass standards.

I concentrated on documentation changes, and left code alone, other than formatting issues. Meaning: mixedCase and under_score are used in the wrong places but I left them so other patches stand a better chance of applying.

This is against the dev branch.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Needs work

We should follow core and have a phpcs.xml.dist file if we're going to care about coding standards: #2571965: [meta] Fix PHP coding standards in core, stage 1 + #2744463: Add phpcs, coder 8.2.8 as --dev requirements for drupal/core

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Component: Code » Coding Standards
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Title: drupalci testbot code should pass drupal coding standards. » [meta] DrupalCI testbot code should pass Drupal coding standards.
Category: Task » Plan

Added #2780083: Add phpcs, coder as --dev requirements for testbot

  • Mixologic committed a1aa6b2 on 2614516-coding-standards-updates 
    Issue #2614516: fixes Drupal.Commenting.FileComment

  • Mixologic committed 1e785f1 on 2614516-coding-standards-updates 
    Issue #2614516: Fixes Generic.PHP.UpperCaseConstant
  • Mixologic committed 4a7c848 on 2614516-coding-standards-updates
    Issue #2614516: Fixes Drupal.Files.EndFileNewline
  • Mixologic committed 77e7205 on 2614516-coding-standards-updates
    Issue #2614516: Fixes remaining sniffs
  • Mixologic committed 84487f4 on 2614516-coding-standards-updates
    Issue #2614516: Fixes Generic.Functions.FunctionCallArgumentSpacing,...
  • Mixologic committed a1c59d1 on 2614516-coding-standards-updates
    Issue #2614516: Everything in phpcs.xml that could be automated
  • Mixologic committed c88a2f7 on 2614516-coding-standards-updates
    Issue #2614516: Fixes Drupal.Classes
  • Mixologic committed dea5a7b on 2614516-coding-standards-updates
    Issue #2614516: Fixes Drupal.Whitespace.Operators/Objects
  • Mixologic committed e3aa600 on 2614516-coding-standards-updates
    Issue #2614516: final standards
  • Mixologic committed edda7a6 on 2614516-coding-standards-updates
    Issue #2614516: Fixes Drupal.Whitespace.Comma

  • Mixologic committed 3acd7bd on 2614516-coding-standards-updates 
    Issue #2614516: adds a buncho phpdoc comments
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Needs work » Fixed

Now that we got down to like, two small branches, I went ahead and updated all of our own sniffyness. DrupalCI testrunner is 100% compliant with our own phpcs.xml.dist. yay.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.