Problem/Motivation
In past_db there's a route definition and a local task for the extended view (/admin/reports/past/extended). But if you remove the view config object, the route definition and the local task remain, and visiting the path causes an error:
Failed to find entity of type past_event_log_key_ext_search in route named entity.past_event.extended in Drupal\Core\Entity\Enhancer\EntityRouteEnhancer->enhanceEntityView()
Proposed resolution
Remove route and local task definitions, they are supposed to be defined in the view config (only).
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | remove_hardcoding_of-2614124-11.patch | 1.11 KB | edurenye |
| #5 | remove_hardcoding_of-2614124-5-interdiff.txt | 4.19 KB | mbovan |
| #5 | remove_hardcoding_of-2614124-5.patch | 9.06 KB | mbovan |
| #5 | remove_hardcoding_of-2614124-5-TEST-ONLY.patch | 3.12 KB | mbovan |
| #3 | remove_hardcoding_of-2614124-3.patch | 5.87 KB | mbovan |
Comments
Comment #2
mbovan commentedThis patch should fix the error.
Comment #3
mbovan commentedSupport for translatable menu item.
Comment #4
edurenye commentedI think we can add that if is there is the extended view but not the standard view, then the menu still appears but leading to the extended view.
For the rest looks perfect!
Comment #5
mbovan commentedImplemented the suggestion from @edurenye and added tests.
Comment #7
berdirNice, committed.
Comment #10
edurenye commentedNow we have to remove the rebuilds in PastDBTest::testViews and the @todo messages as this issue #2596345: Deleting a view should rebuild the routes is fixed, not sure if here or in a followup.
Comment #11
edurenye commentedRemoved here.
Comment #12
berdirThanks, committed.