See:#1567684-26: Adding rel="next" and rel="prev" metatags to paginated views pages

We need clearer recreate stapes to ensure that we have fixed the issue and to possibly add a test to protect against regression.

But have implemented an approach suggest by @sebumd on #2502453-3: How to best use rel=next/prev in Views pages?

Patch to follow and will merge in whether it fixes this or not because it is an improvement but will leave open until people confirm that it is fixed.

CommentFileSizeAuthor
#6 module_doesn_t_work-2613216-5.patch1.73 KBnlisgo

Comments

nlisgo created an issue. See original summary.

nlisgo’s picture

nlisgo commented
Priority: Normal » Major
nlisgo’s picture

nlisgo commented
Issue summary: View changes
nlisgo’s picture

nlisgo commented
Title: Module doesn't work with metatags module enable » Module doesn't work with metatags module enabled

  • nlisgo committed 377c89a on 7.x-1.x 
    Issue #2613216 by nlisgo, sebumd: Module doesn't work with metatags...
nlisgo’s picture

nlisgo commented
StatusFileSize
new module_doesn_t_work-2613216-5.patch1.73 KB

This has been committed to 7.x-1.x now with a credit for @sebumd.

Please reopen this issue if it is still not working with metatag module.

nlisgo’s picture

nlisgo commented
Status: Active » Needs review
nlisgo’s picture

nlisgo commented
Status: Needs review » Closed (fixed)
jehu’s picture

jehu commented

Thanks @nlisko for that patch.
My pull request to your git repo is another solution based on @sebumd's hint.

nlisgo’s picture

nlisgo commented

@Jehu, thanks for the pull request. I can't believe I missed it. I'm sorry about that. i didn't expect people to be adding stuff there but I use the GitHub so I can do the test runs on travis.

What do you think of my implementation? Can you confirm that it solves the issue?

In future when you submit pull requests on GitHub could you also creat an issue here? That would be fantastic.

nlisgo’s picture

nlisgo commented

Also, so I can give you a credit for an issue on this project can you add your voice to this issue: #2384401: What shall we call this module?

It will help me to promote it to a full project soon if I can get some agreement on the name of the module.

jehu’s picture

jehu commented

@nlisgo sorry for the late reply.
I have a problem with this, because after cache recreation the next/prev links are no more generated. I've no clue why this happens. Tested with your patch and with mine also.

EDIT
Argh, after deactivating Views cache for this view it works. But i need caching here...

nlisgo’s picture

nlisgo commented

@Jehu, great feedback thanks. I will try to recreate when I can give this issue some time. Or actually, can I suggest that you open this as a new issue?

jehu’s picture

jehu commented

@nlisgo i've added my comment to the existing issue #2575767