The form builder service is being retrived from the container but it is not used anywhere, so there is no need for the container call at all.

CommentFileSizeAuthor
#2 2612580-2.patch655 byteshchonov

Comments

hchonov created an issue. See original summary.

hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented
Status: Active » Needs review
StatusFileSize
new 2612580-2.patch655 bytes
bojanz’s picture

bojanz commented
Status: Needs review » Reviewed & tested by the community

Indeed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Totally dead code that adds unnecessary dependencies to this class. Committed 4fcf4b7 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed 62d5085 on 8.1.x 
    Issue #2612580 by hchonov: Remove unused service from WidgetBase::...

  • alexpott committed 4fcf4b7 on 
    Issue #2612580 by hchonov: Remove unused service from WidgetBase::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -rc target triage