After #2566597: [Mega patch] Move system *.theme.css files to Classy was committed you can still lock colors together in the UI but you cannot actually see the locks.
It looks like this:
It should look like this:
Here is the CSS specificity conflict/issue via Chrome's inspector:
Fix it.
Patch
Manual testing
You will be able to see the locks again.
n/a
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2612150-10-after.png | 45.17 KB | star-szr |
| #10 | locks_background_fix-2612150-10.patch | 1.54 KB | lobsterr |
| #5 | locks_background_fix-2612150-5.patch | 1.1 KB | lobsterr |
| #2 | 2612150-background-transparent.png | 40.39 KB | star-szr |
| #2 | 2612150-working-locks.png | 37.07 KB | star-szr |
Comments
Comment #2
star-szrOkay so the locking still works you just can't see the lock. Updating issue summary with new screenshots and information and tagging.
Comment #3
davidhernandezAha! So that's what the hook is!
It is link.css that is breaking it. Any idea where that CSS originated? It is currently in Classy, but I don't see it in core.
Comment #4
lobsterr commentedComment #5
lobsterr commentedComment #6
lobsterr commentedComment #7
star-szrManual testing seems to check out, thanks @LOBsTerr!
This should probably go in after #2575737: Copy templates, CSS, and related assets to Stable and override core libraries' CSS, and update Stable's color.admin.css as well. To make this clear, postponing for now.
Comment #8
star-szr#2575737: Copy templates, CSS, and related assets to Stable and override core libraries' CSS is in, so this should also update Stable's color.admin.css.
Comment #9
lobsterr commentedComment #10
lobsterr commentedComment #11
star-szrNice thanks!
Comment #12
star-szrLooks good and manual testing checks out, RTBC'ing with the knowledge that this will not go in until after 8.0.0 is released, not sure how else to indicate that.
Comment #13
star-szrAlso here's an "after" screenshot:
Comment #14
alexpottManual testing shows that this patch works as expected. As this is a bug fix and the color locks are completely unusable without committing to 8.0.x for inclusion in the next patch release. Although there are CSS additions I don't think this will break any sites since it is admin only. Committed 4227ef6 and pushed to 8.0.x and 8.1.x. Thanks!
Comment #17
alexpottAdding @Cottser to the credit list.