API page: https://api.drupal.org/api/drupal/modules%21simpletest%21drupal_web_test...

The docs for the 2nd param are missing.

Looks like they can be backported from https://api.drupal.org/api/drupal/core!modules!simpletest!src!AssertCont....

CommentFileSizeAuthor
#9 2611274-9.patch558 bytesfelribeiro
#6 2611274-6.patch552 bytesfelribeiro
#3 2611274-3.patch559 bytesfelribeiro

Comments

joachim created an issue. See original summary.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Version: 8.0.x-dev » 7.x-dev

seems like wrong version :)

felribeiro’s picture

felribeiro commented
StatusFileSize
new 2611274-3.patch559 bytes
felribeiro’s picture

felribeiro commented
Status: Active » Needs review
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs review » Needs work 
+++ b/modules/simpletest/drupal_web_test_case.php
@@ -2584,6 +2584,11 @@
+   *   placeholders in the query. The values may be either strings or numeric
+   *   values.
+   * ¶
    * @return

white space

felribeiro’s picture

felribeiro commented
StatusFileSize
new 2611274-6.patch552 bytes
felribeiro’s picture

felribeiro commented
Status: Needs work » Needs review
joachim’s picture

joachim commented
Status: Needs review » Needs work

Not quite there, I'm afraid. Should have an empty line before the @return -- the problem #3 was that there was a stray space character after the *.

felribeiro’s picture

felribeiro commented
StatusFileSize
new 2611274-9.patch558 bytes

Thank you for your help.

felribeiro’s picture

felribeiro commented
Status: Needs work » Needs review
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Perfect! Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 7.x-dev » 8.0.x-dev
Status: Reviewed & tested by the community » Active

Thanks! This patch also looks good to me, and should be committed to 7.x.

However, the 8.x equivalent, DrupalWebTestCase::xpath(), also needs the same fix first.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Assigned: Unassigned » joshi.rohit100
anchal29’s picture

anchal29 commented

I would like to work on the issue.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

@anchal29, the first step would normally be to find the "Assigned" field in "Issue metadata", and assign the issue to yourself. However, joshi.rohit100 recently assigned the issue to himself, so you should find a different issue instead that isn't assigned to someone. Thanks!

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Assigned: joshi.rohit100 » Unassigned

@anchal29 - I am unassigning myselfy. You can now work on this.

anchal29’s picture

anchal29 commented

@jhodgdon, I'm new here so thanks for the help!
The 8.x equivalent already contains doc for the argument parameter which is backported right, so what should be fixed here?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.0.x-dev » 7.x-dev
Status: Active » Reviewed & tested by the community

Doh! You are right, the 8.x functions are fine. Sorry about that! I must have been looking at 7.x and gotten confused.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed 27e511b on 7.x 
    Issue #2611274 by felribeiro, joachim, joshi.rohit100, anchal29: missing...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.