Problem/Motivation

Now that we have splitted up the entity manager, yeah!, we should expose the entity type manager in more places.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 interdiff.txt1.81 KBxjm
#7 entity-2611086-7.patch4.36 KBxjm
#5 interdiff.txt1.71 KBdawehner
#5 2611086-5.patch4.02 KBdawehner
#2 2611086-2.patch3.75 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2611086-2.patch3.75 KB

There we go

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Expose entity type repository on controller base / Entity / Drupal » Expose entity type manager on controller base / Entity / Drupal
Status: Needs review » Reviewed & tested by the community
Issue tags: +rc target triage
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -rc target triage +rc target

The added \Drupal method for the entity type manager makes total sense. The one thing that is missing is that the @deprecated should tell people what they should use instead (one of the many services that were added, including but not limited to the entity type manager).

@effulgentsia and I agreed on this being an RC target.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2611086-5.patch4.02 KB
new interdiff.txt1.71 KB

There we go, good point.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

I think that's good enough.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new entity-2611086-7.patch4.36 KB
new interdiff.txt1.81 KB

I'd suggest this.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Even better.

dawehner’s picture

dawehner
Primary language German
commented

Oh yeah indeed!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 8485135 and pushed to 8.0.x. Thanks!

  • alexpott committed 8485135 on 8.0.x 
    Issue #2611086 by dawehner, xjm: Expose entity type manager on...

  • alexpott committed 8485135 on 8.1.x 
    Issue #2611086 by dawehner, xjm: Expose entity type manager on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.