Add an AssertMailTrait to allow mail testing in Kernel tests and fix odd stdout not found in test output

Could you attach the console output around the failure from docker?

Output I found in one of the error logs:

22:17:49 Drupal\migrate_drupal\Tests\d6\CckMigrationBuilderTest         3 passes                                      
22:17:50 sh: 1: -t: not found
22:17:51 Drupal\action\Tests\Migrate\d6\MigrateActionConfigsTest        5 passes 

This is from a different test. It is close to the output in the previous test.

23:12:09 Drupal\migrate_drupal\Tests\d6\CckMigrationBuilderTest         3 passes                                      
23:12:09 Drupal\menu_ui\Tests\MenuLanguageTest                         47 passes                                      
23:12:09 Drupal\menu_ui\Tests\MenuUninstallTest                         2 passes                                      
23:12:10 sh: 1: -t: not found
23:12:10 Drupal\locale\Tests\LocaleConfigTranslationTest              149 passes                                      
23:12:10 Drupal\locale\Tests\LocalePluralFormatTest                   242 passes                                      
23:12:10 Drupal\action\Tests\Migrate\d6\MigrateActionConfigsTest        5 passes                                      
23:12:12 Drupal\aggregator\Tests\Migrate\d6\MigrateAggregatorConfigsT  11 passes                                      

\drupal\vendor\behat\mink-goutte-driver\.travis.yml

Has the following:

before_script:
  - export WEB_FIXTURES_HOST=http://localhost:8000

  # Start a webserver for web fixtures. Force using PHP 5.6 to be able to run it on PHP 5.3 and HHVM jobs too
  - ~/.phpenv/versions/5.6/bin/php -S localhost:8000 -t vendor/behat/mink/driver-testsuite/web-fixtures > /dev/null 2>&1 &

This is very likely related to the following:
http://axiac.ro/blog/2013/06/sh-1-t-not-found/

A quick look inside one of the containers shows the following:

root@2d48ed06f3d8:/# php -i |grep sendmail
sendmail_from => no value => no value
sendmail_path =>  -t -i  =>  -t -i 
Path to sendmail =>  -t -i 
root@2d48ed06f3d8:/# 

So the next question is, what, from inside of the testrunners, is trying to send mail, but only sometimes?

This is caused by Drupal\migrate_drupal\Tests\d6\EntityContentBaseTest - it is a KernelTestBase test.

"sh: 1: -t: not found" was not found in the test output! :)

Nice find Alex. Looks like we see it on occasion whenever something inadvertently sends mail.

Also, slightly disturbing that sendmail_path is essentially a shell vector. Yet another reason one should never allow their webserver process to have too many permissions.

+1 to always use the test mail collector, its what you always want. In case you want something else, you can still switch over.
I guess the odd message is not visible on the old testbase, because you have a different error handler?

Patch is now back to green.

We still need tests for this in both KernelTestBaseTests

Maybe a duplicate of #2146971: SimpleTest should override all mail system implementations with TestMailCollector

This combines #2675202: Add an AssertMailTrait to allow mail testing in Kernel tests as suggested there. With this, then all tests that choose to use the new trait will be able to assert email results. Setting NR, although tests are still needed.

Added a test and fixed some coding standards. I don't think the deprecated KernelTestBase should be tested because there is massive work on to remove all the usages of this.

WebTestBase has existing test coverage in Drupal\simpletest\Tests\MailCaptureTest... the test added here is a verbatim copy of that and just a couple of changes for phpunit style assertions.

Nice work!

1. +++ b/core/tests/Drupal/KernelTests/Core/Test/AssertMailTraitTest.php
   @@ -0,0 +1,91 @@
   +      $this->assertMail($field, $value, sprintf('The email was sent and the value for property %s is intact.', $field));
   

   Is there some real value in the sprintf here?

2. +++ b/core/tests/Drupal/KernelTests/Core/Test/AssertMailTraitTest.php
   @@ -0,0 +1,91 @@
   +    // Test different ways of getting filtered emails via drupalGetMails().
   ...
   +    // drupalGetMails-filter correctly returns all emails with a given
   

   these docs still refer to the old function names.

thanks for the review @dawehner patch fixes all of that

Cool

Committed/pushed to all three 8.x branches, thanks!

Er adding review credit post-commit.

Why was this copied from WebTestBase but changed from a normal config set to an override? That goes against the accompanying comment statement "some tests expect to be able to test mail system implementations" because now they cannot.

How about changing to a config set like in WebTestBase?

@Arla they can just set the global and be done - no?

Also I don't think re-opening the issue is necessary - if we want to change this we can open another issue and add comments here to point people to it.