Failures when fetching a remote URL will be cached using cache_set(). For further request the URL is compared to the entries in the cache. Here a wrong $cid is used with cache_get() with the result of never matching any entry. Probably this is a typo which the attached patch does fix.

CommentFileSizeAuthor
#2 retrieving_cached_fetch_failures_fails-2609292.patch485 bytesfuerst

Comments

fuerst created an issue. See original summary.

fuerst’s picture

fuerst commented
StatusFileSize
new retrieving_cached_fetch_failures_fails-2609292.patch485 bytes
fuerst’s picture

fuerst commented
Status: Active » Needs review

  • greggles committed 7dc5707 on 7.x-1.x authored by fuerst 
    Issue #2609292 by fuerst: Retrieving cached fetch failures fails
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

I fixed this by making them consistent, but in the opposite way. I think the longer cid name is a bit more descriptive which may be useful.

Seem OK?

Thanks for noticing this!

fuerst’s picture

fuerst commented

Completely OK - thanks a lot!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.