Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 2608126-7.patch1.27 KBjoshi.rohit100

Comments

dawehner created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +rc eligible, +Novice

Dead code - let's do it.

dawehner’s picture

dawehner
Primary language German
commented
Title: Drop the unused function \Drupal\Core\DependencyInjection\ContainerBuilder::synchronize ? » Drop the unused function \Drupal\Core\DependencyInjection\ContainerBuilder::synchronize !
dawehner’s picture

dawehner
Primary language German
commented

Well, the actual question is whether we need anything from it still, but it seems not.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@dawehner I really hope not synchronising containers is awful

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Assigned: Unassigned » joshi.rohit100
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Assigned: joshi.rohit100 » Unassigned
Status: Active » Needs review
StatusFileSize
new 2608126-7.patch1.27 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Cool

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 2159328 on 8.0.x 
    Issue #2608126 by joshi.rohit100: Drop the unused function \Drupal\Core\...

  • catch committed 2159328 on 8.1.x 
    Issue #2608126 by joshi.rohit100: Drop the unused function \Drupal\Core\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.