Closed (fixed)
Project:
Drupal core
Version:
8.2.x-dev
Component:
theme system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Nov 2015 at 17:45 UTC
Updated:
17 Aug 2016 at 00:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
krknth commentedAdded patch
Comment #3
jhodgdonSomeone needs to review this carefully. I am not sure whether:
- these are actually present (I didn't look through the code to figure this out)
- if we normally document them. They look kind of like standard attributes that are present on pretty much every Twig file, so I am not sure we document them in every Twig file?
Hopefully the Twig maintainers will figure this out... moving to theme component since it needs some expert reviewing.
Comment #4
krknth commentedComment #5
joelpittetYes we usually document the variables that we use in the template and they are in the templates.
The work that needs to be done is for this to be added to each template in classy/stable too.
Comment #6
joelpittetAlso they are the magic ones that get added to every template via _template_preprocess_default_variables().
Please ensure the text for the documentation is the same as for those same variables, elsewhere in core.
Comment #7
Erno commentedComment #8
Erno commentedI added missing variables documentation to these files:
There is still variable 'full' that is not documented. The value is assigned in core\modules\aggregator\aggregator.theme.inc (line 48):
Comment #9
imiksuCleaning up drupalcampfi tags.
Comment #11
nikhilesh gupta commentedComment #12
reedcodes commentedI reviewed 2607548-8.patch: the title variables have been updated, plus documentation for those variables, in core, classy, and stable template files for the aggregator module.
Comment #14
catchCommitted/pushed to 8.1.x and 8.2.x, thanks!