The following twig files in aggregator module has missing available variables list - title_attributes, title_prefix, title_suffix, attributes

core/modules/aggregator/templates/aggregator-feed.html.twig
core/modules/aggregator/templates/aggregator-item.html.twig

Comments

krknth created an issue. See original summary.

krknth’s picture

Status: Active » Needs review
FileSize
1.81 KB

Added patch

jhodgdon’s picture

Component: documentation » theme system

Someone needs to review this carefully. I am not sure whether:
- these are actually present (I didn't look through the code to figure this out)
- if we normally document them. They look kind of like standard attributes that are present on pretty much every Twig file, so I am not sure we document them in every Twig file?

Hopefully the Twig maintainers will figure this out... moving to theme component since it needs some expert reviewing.

krknth’s picture

Assigned: krknth » Unassigned
joelpittet’s picture

Status: Needs review » Needs work
Issue tags: +rc eligible, +documentation, +Novice

Yes we usually document the variables that we use in the template and they are in the templates.

The work that needs to be done is for this to be added to each template in classy/stable too.

joelpittet’s picture

Also they are the magic ones that get added to every template via _template_preprocess_default_variables().

Please ensure the text for the documentation is the same as for those same variables, elsewhere in core.

Erno’s picture

Assigned: Unassigned » Erno
Issue tags: +drupalcampfi
Erno’s picture

Assigned: Erno » Unassigned
Status: Needs work » Needs review
FileSize
5.53 KB

I added missing variables documentation to these files:

core\themes\classy\templates\content\aggregator-item.html.twig
core\themes\classy\templates\dataset\aggregator-feed.html.twig
core\themes\stable\templates\content\aggregator-item.html.twig
core\themes\stable\templates\dataset\aggregator-feed.html.twig

There is still variable 'full' that is not documented. The value is assigned in core\modules\aggregator\aggregator.theme.inc (line 48):

function template_preprocess_aggregator_feed(&$variables) {
...
$variables['full'] = $variables['elements']['#view_mode'] == 'full';
...
}
iMiksu’s picture

Issue tags: -drupalcampfi

Cleaning up drupalcampfi tags.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Nikhilesh Gupta’s picture

Version: 8.1.x-dev » 8.2.x-dev
ReedCodes’s picture

Status: Needs review » Reviewed & tested by the community

I reviewed 2607548-8.patch: the title variables have been updated, plus documentation for those variables, in core, classy, and stable template files for the aggregator module.

  • catch committed a4c4831 on 8.2.x
    Issue #2607548 by krknth, Erno: Missing title_prefix, title_suffix,...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and 8.2.x, thanks!

  • catch committed ab14cdf on 8.1.x
    Issue #2607548 by krknth, Erno: Missing title_prefix, title_suffix,...

  • catch committed a4c4831 on 8.3.x
    Issue #2607548 by krknth, Erno: Missing title_prefix, title_suffix,...

  • catch committed a4c4831 on 8.3.x
    Issue #2607548 by krknth, Erno: Missing title_prefix, title_suffix,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.