Problem/Motivation

See #2585173-44: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI and #2585173-45: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI:

Does drupalunlink command need the allowedContent setting? It does not create anything.

Hah! We've had this since the very issue where we introduced the drupallink plugin: #1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms. This went unnoticed all that time, including by @wwalc, who reviewed that issue. Removed, thanks!

Proposed resolution

Remove it; it's pointless to have allowedContent for something that doesn't create anything.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Issue summary: View changes
Wim Leers’s picture

Status: Active » Needs review
FileSize
1006 bytes
Wim Leers’s picture

Wim Leers’s picture

FileSize
765 bytes

Oops, #4 removed requiredContent also.

Wim Leers’s picture

Reinmar’s picture

+1 for #5.

Wim Leers’s picture

Status: Needs review » Postponed

Let's do this in a 8.0.x release, no need to do this during RC. This is pure clean-up.

Wim Leers’s picture

Status: Postponed » Needs review

8.0.0 is out. Blocked only on manual testing.

Status: Needs review » Needs work

The last submitted patch, 5: 2607454-5.patch, failed testing.

Devin Carlson’s picture

Status: Needs work » Needs review
FileSize
630 bytes

Manually tested #5 with Chrome and verified that links could continue to be unlinked successfully. There were no issues with new/existing links, links were removed from the source markup and there were no JS errors in the console.

Attached is a simple reroll required due to #2585173: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI.

Devin Carlson’s picture

Status: Needs review » Reviewed & tested by the community

The last submitted patch, 5: 2607454-5.patch, failed testing.

Wim Leers’s picture

Thank you!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

  • catch committed edc125a on 8.1.x
    Issue #2607454 by Wim Leers, Devin Carlson: Remove allowedContent for...

  • catch committed 2b22c6a on
    Issue #2607454 by Wim Leers, Devin Carlson: Remove allowedContent for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.