Problem/Motivation
See #2585173-44: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI and #2585173-45: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI:
Doesdrupalunlink
command need theallowedContent
setting? It does not create anything.Hah! We've had this since the very issue where we introduced the
drupallink
plugin: #1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms. This went unnoticed all that time, including by @wwalc, who reviewed that issue. Removed, thanks!
Proposed resolution
Remove it; it's pointless to have allowedContent
for something that doesn't create anything.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#11 | 2607454-11.patch | 630 bytes | Devin Carlson |
#5 | 2607454-5.patch | 765 bytes | Wim Leers |
|
Comments
Comment #2
Wim LeersComment #3
Wim LeersComment #4
Wim LeersShould go in after #2585173: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI, but can already be reviewed.
Comment #5
Wim LeersOops, #4 removed
requiredContent
also.Comment #6
Wim LeersComment #7
Reinmar CreditAttribution: Reinmar commented+1 for #5.
Comment #8
Wim LeersLet's do this in a 8.0.x release, no need to do this during RC. This is pure clean-up.
Comment #9
Wim Leers8.0.0 is out. Blocked only on manual testing.
Comment #11
Devin Carlson CreditAttribution: Devin Carlson commentedManually tested #5 with Chrome and verified that links could continue to be unlinked successfully. There were no issues with new/existing links, links were removed from the source markup and there were no JS errors in the console.
Attached is a simple reroll required due to #2585173: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI.
Comment #12
Devin Carlson CreditAttribution: Devin Carlson commentedComment #14
Wim LeersThank you!
Comment #15
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!