See #2585173-44: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI and #2585173-45: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI:
Doesdrupalunlinkcommand need theallowedContentsetting? It does not create anything.Hah! We've had this since the very issue where we introduced the
drupallinkplugin: #1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms. This went unnoticed all that time, including by @wwalc, who reviewed that issue. Removed, thanks!
Remove it; it's pointless to have allowedContent for something that doesn't create anything.
None.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 2607454-11.patch | 630 bytes | devin carlson |
| #5 | 2607454-5.patch | 765 bytes | wim leers |
Comments
Comment #2
wim leersComment #3
wim leersComment #4
wim leersShould go in after #2585173: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI, but can already be reviewed.
Comment #5
wim leersOops, #4 removed
requiredContentalso.Comment #6
wim leersComment #7
reinmar commented+1 for #5.
Comment #8
wim leersLet's do this in a 8.0.x release, no need to do this during RC. This is pure clean-up.
Comment #9
wim leers8.0.0 is out. Blocked only on manual testing.
Comment #11
devin carlson commentedManually tested #5 with Chrome and verified that links could continue to be unlinked successfully. There were no issues with new/existing links, links were removed from the source markup and there were no JS errors in the console.
Attached is a simple reroll required due to #2585173: [regression] "Allowed HTML tags" setting corrupted upon accessing Text Format configuration UI.
Comment #12
devin carlson commentedComment #14
wim leersThank you!
Comment #15
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!