Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
datetime.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Nov 2015 at 02:51 UTC
Updated:
3 Dec 2015 at 17:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tim.plunkettComment #3
alexpottSetting the correct version
Comment #4
tim.plunkettWhoops, thanks. Reuploading to get the bot to run
Comment #6
dawehnerLooks great for me! In an ideal world, the helper would not be a static method, but we cannot change this anymore, I guess and its out of scope of this issue.
PS: Does someone mind to document that we need assertSame due to checking for the array order?
Comment #7
tim.plunkettFair point.
Comment #8
dawehnerThank you!
Comment #11
tim.plunkettComment #12
xjm@effulgentsia and I agreed that this is definitely a valid RC target as a contrib blocker and non-disruptive bugfix.
Comment #14
tim.plunkettUnrelated fail, the recent testrun passed.
Comment #15
alexpottWe should be documenting the expectation on the return value of
DateHelper::weekDaysOrdered()Comment #16
tim.plunkettComment #17
alexpottCommitted 235472c and pushed to 8.0.x. Thanks!