Until we get the option to pull in custom confs we'll the gettext.ini will be needed.

Comments

isntall created an issue. See original summary.

isntall’s picture

Status: Active » Needs review

The web-5.3:dev container has been rebuilt with the needed php extension and the d7 tests pass
https://dispatcher.drupalci.org/job/staging_simpletest_job/277//
https://dispatcher.drupalci.org/job/staging_simpletest_job/278/

mondrake’s picture

Thank you, I can confirm this is a fix for the problem I raised in #2569065-11: Failure on contrib module Textimage i.e. the test failures of the Textimage 7 module versions. I cannot grasp all the implications though (does it need to be moved to production, will other module be impacted, etc) so leaving in NR status for other reviews.

isntall’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs deployment

Although this code is not in production it should make into the next build, which should be soon (hopefully tomorrow).

isntall’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs deployment

I've re-ran the Drupal 7 tests and they came back green.

Marking fixed.

mondrake’s picture

Works great. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.