Problem/Motivation

As of https://docs.google.com/document/d/1BxgNvyIRcxYGzzA1DLkZ6A4-c8gGFixypNvP... we want to make clear which bits of the URL generation
machinery should be used

Proposed resolution

* \Drupal\Core\Routing\UrlGeneratorInterface::generate() should be marked as internal.
* It should point to \Drupal\Core\Url instead

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 interdiff-2606378-4-7.txt764 bytesanil280988
#8 2606378-7.patch795 bytesanil280988
#6 2606378-6.patch737 byteskaushalkishorejaiswal
#4 2606378-4.patch786 bytessdstyles

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
commented
Component: base system » documentation
sdstyles’s picture

sdstyles commented
Status: Active » Needs review
StatusFileSize
new 2606378-4.patch786 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Routing/UrlGeneratorInterface.php
@@ -77,6 +77,9 @@ public function getPathFromRoute($name, $parameters = array());
+   * @internal Should not be used in user code.
+   *   Use \Drupal\Core\Url instead.

I don't think we put documentation along with the @internal tag? We do that with @deprecated, but I think @api and @internal are stand-alone tags.

kaushalkishorejaiswal’s picture

kaushalkishorejaiswal commented
Status: Needs work » Needs review
StatusFileSize
new 2606378-6.patch737 bytes

Status: Needs review » Needs work

The last submitted patch, 6: 2606378-6.patch, failed testing.

anil280988’s picture

anil280988 commented
Status: Needs work » Needs review
StatusFileSize
new 2606378-7.patch795 bytes

Keeping @internal tag separate.

anil280988’s picture

anil280988 commented
StatusFileSize
new interdiff-2606378-4-7.txt764 bytes

Adding Interdiff file.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +rc eligible

Thank you

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 67d9c3e on 8.0.x 
    Issue #2606378 by anil280988, kaushalkishorejaiswal, sdstyles: mark \...

The last submitted patch, 6: 2606378-6.patch, failed testing.

  • catch committed 67d9c3e on 8.1.x 
    Issue #2606378 by anil280988, kaushalkishorejaiswal, sdstyles: mark \...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.