Problem/Motivation

In order to have css tests at some point for core it would be nice to have css lint installed on the testrunner.

#2575497: DrupalCI should report code style issues - CSS

Proposed resolution

Add csslint to container

Remaining tasks

  • Needs community review
  • Needs maintainer review and branch/ci test
CommentFileSizeAuthor
#4 2605308-02.patch748 byteselachlan
#3 2605308-01.patch533 byteselachlan

Comments

elachlan created an issue. See original summary.

elachlan’s picture

elachlan commented
Issue summary: View changes
elachlan’s picture

elachlan commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2605308-01.patch533 bytes
elachlan’s picture

elachlan commented
StatusFileSize
new 2605308-02.patch748 bytes

Forgot to add npm and nodejs.

elachlan’s picture

elachlan commented
Issue summary: View changes
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Component: Code » Jobs and Job Handling
elachlan’s picture

elachlan commented
Status: Needs review » Needs work

Does this need to change to a plugin? Similar to #2575501: [PP-2] DrupalCI should return failed for poor code style - JS?

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Needs work » Fixed

csslint is installed on the testrunners now, we'll still create a build the plugin to use it though.

Im about 90% of the way through the eslint one, so the csslint one will be somewhat identical to that one.

This happened as part of this commit: http://cgit.drupalcode.org/infrastructure/commit/?id=c560a95e76e20e34fc7...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.