Problem/Motivation

url is wrong, route is correct, because HelpBlock does 

$help = $this->moduleHandler->invokeAll('help', array($this->routeMatch->getRouteName(), $this->routeMatch));

Proposed resolution

Fix it.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Why during RC?

Because core setting the right example wrt cacheability metadata is important: developers will look at core's examples and learn from them, core being wrong is problematic.

CommentFileSizeAuthor
#3 2604098-3.patch2.27 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Postponed
StatusFileSize
new 2604098-3.patch2.27 KB

Blocked on #2541344: BlockBase subclasses should merge their cache tags/contexts with the parent's (BlockBase's) because patch is relative to that.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: HelpBlock has the 'url' cache context instead of 'route' » [PP-1] HelpBlock has the 'url' cache context instead of 'route'
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] HelpBlock has the 'url' cache context instead of 'route' » HelpBlock has the 'url' cache context instead of 'route'
Status: Postponed » Needs review

#2541344: BlockBase subclasses should merge their cache tags/contexts with the parent's (BlockBase's) landed, unpostponing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: -rc target triage
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Is this really a bug fix or task for 8.1.x?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2604098-3.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community

Testbot fluke.

  • catch committed b95ae50 on 8.1.x 
    Issue #2604098 by Wim Leers: HelpBlock has the 'url' cache context...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

Well the bad caching is the bug.

But given the fix caused unrelated test failures, and that might potentially affect contrib tests too which we shouldn't unnecessarily break in patch releases, just committing to 8.1.x for now. Committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.