Remaining tasks:

Validate with http://pareview.sh/pareview/httpgitdrupalorgprojectpotranslationsreportg...

CommentFileSizeAuthor
#15 po_translations_report-fix_deprecated-2603796-15.patch20.17 KBgrimreaper
#2 po_translations_report-add_composer_json-2603796-2.patch616 bytesgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs review
StatusFileSize
new po_translations_report-add_composer_json-2603796-2.patch616 bytes
izus’s picture

izus commented
Issue summary: View changes

  • izus committed c611dbb on 8.x-1.x authored by Grimreaper 
    Issue #2603796 by Grimreaper, izus: Add composer.json file.
izus’s picture

izus commented
Issue summary: View changes

  • izus committed 93ba08e on 8.x-1.x 
    Issue #2603796 by izus: Answer pareview.sh concerns

  • izus committed c93a38b on 8.x-1.x 
    Issue #2603796 by izus: Answer pareview.sh concerns

  • izus committed fd59d14 on 
    Issue #2603796 by izus: Answer pareview.sh concerns

  • izus committed 324b189 on 8.x-1.x 
    Issue #2603796 by izus: Answer pareview.sh concerns

Status: Needs review » Needs work

The last submitted patch, 2: po_translations_report-add_composer_json-2603796-2.patch, failed testing.

  • izus committed 0561c66 on 8.x-1.x 
    Issue #2603796 by izus: Answer pareview.sh concerns

  • izus committed d816db9 on 8.x-1.x 
    Issue #2603796 by izus: Answer pareview.sh concerns
izus’s picture

izus commented
Version: 8.x-1.x-dev » 8.x-1.0
Status: Needs work » Fixed

And first release published :)

izus’s picture

izus commented
Status: Fixed » Closed (fixed)
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new po_translations_report-fix_deprecated-2603796-15.patch20.17 KB

Hello,

Good work for the stable release :)

Here is a patch that fix the deprecated functions and get rid of the Drupal macro object and use dependency injection instead.

Thanks for the review.

theodorosploumis’s picture

theodorosploumis
he/him
Location Greece
commented

Any progress on this patch? Thank you.

  • Grimreaper authored 54d8541 on 8.x-1.x 
    Issue #2603796 by Grimreaper, izus, TheodorosPloumis: [D8 version]
izus’s picture

izus commented
Status: Needs review » Fixed

wow, this one was forgotten ! thanks TheodorosPloumis for the ping and thanks Grimreaper for the patch
this is now merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.