aws_sqs.queue.inc currently has a comment near the top stating:

Drupal coding standards discourage use of private properties. AwsSqs properties here are private to encourage clients to use the DrupalQueue interface, and to hide and harden SQS-specific logic

In a project I needed to extend the AwsSqsQueue class to create a new setName() method (to allow different queues that all use SQS to have different prefix conventions), but the methods and properties in AwsSqsQueue being private caused no end of headaches. As the Drupal coding standards discourage the use of private I would like to see the properties and methods moved back to being protected.

CommentFileSizeAuthor
#2 make-queue-properties-functions-protected-2603730-2.patch5.3 KBlahoosascoots

Comments

orbmantell created an issue. See original summary.

lahoosascoots’s picture

lahoosascoots commented
Status: Active » Needs review
StatusFileSize
new make-queue-properties-functions-protected-2603730-2.patch5.3 KB

Patch attached.

orbmantell’s picture

orbmantell commented
Status: Needs review » Reviewed & tested by the community

This patch accomplishes exactly what I want.

  • skwashd committed ee583ff on 7.x-3.x authored by lahoosascoots 
    Issue #2603730 by lahoosascoots, skwashd: Methods and properties should...
skwashd’s picture

skwashd commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Thanks for the patch. This is something that has bugged me for a while. Protected allows the class to be easily extended, but avoids the tight coupling discussed in the (removed) documentation.

I have committed this on the 7.x-1.x branch and an updated version on the new 7.x-3.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.