profile2_access() has an optional second parameter but tries to use $profile->type right away

How about this? It also makes a slight improvement to the administer profiles for micro performance optimization.

I just noticed in my error log and doesn't happen often.

Though if profile is default null like the docs say it can be it with throw this notice

@Spleshka it does fix it because your function parameter defaults to NULL and the docs say it is optional.

 * @param $profile
 *   (optional) A profile to check access for. If nothing is given, access for
 *   all profiles is determined.

So regardless of where the error came from the expected code path of an optional profile is that it can deal with $profile being not a profile object and therefore doesn't have a type property.

To reproduce just call:

profile2_access($op = 'view');

Here's some tests to help prove this. Also I noticed the defaults on $account weren't defaulting like the param docblock says so I added a test for that too.

Whoops too used to D8's short array syntax.

Whoops, don't use #10 that opens up some security issues because there is a $user variable in that function. I renamed it and this one is much better.

@Spleshka I did that because that's what user_access() does it. But since user_access() does that for itself and I'd have to assume that the implementations of hook_profile2_access() can deal with the NULL value already, then that is fine.

I guess I can't RTBC my own patch but maybe you feel comfortable enough with the tests and such that it's worth committing?