Fix few minor comment standards for filter module.

CommentFileSizeAuthor
#6 2601610-3.patch2.4 KBkrknth
#2 2601610-1.patch2.27 KBkrknth

Comments

krknth created an issue. See original summary.

krknth’s picture

krknth commented
Status: Active » Needs review
StatusFileSize
new 2601610-1.patch2.27 KB

Added patch

krknth’s picture

krknth commented
Assigned: krknth » Unassigned
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks! This all looks fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/filter/src/Controller/FilterController.php
@@ -17,7 +17,7 @@ class FilterController {
    *   A filter format, or NULL to show tips for all formats. Defaults to NULL.

Should have (optional) in front of the param description. See https://www.drupal.org/coding-standards/docs#param

krknth’s picture

krknth commented
Status: Needs work » Needs review
StatusFileSize
new 2601610-3.patch2.4 KB

@alexpott : updated patch with your comment.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good! Sorry for missing that in my earlier review. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6513bac and pushed to 8.0.x. Thanks!

  • alexpott committed 6513bac on 8.0.x 
    Issue #2601610 by krknth: Fix comment standards for filter module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.