Problem/Motivation

Later versions of Twig add a $throw parameter to Twig loaders' findTemplate() calls. Our ThemeRegistryLoader doesn't have this so it needs to be added.

Why this should be an RC target

This is not disruptive, we should do it before 8.0.0 so that we are ready to upgrade to Twig 2.x at a later time.

Per @effulgentsia in #2568181-45: [meta] Get ready to upgrade to Twig 2.x:

I discussed this with the other committers, and yes to removing Drupal core usages of @deprecated Twig 1.x APIs being "rc target" material.

Proposed resolution

Add it.

Remaining tasks

Patch
Review

User interface changes

n/a

API changes

Should be none.

Data model changes

None

Files: 
CommentFileSizeAuthor
#2 make-2600152-2.patch1.37 KBCottser

Comments

Cottser created an issue. See original summary.

Cottser’s picture

Assigned: Cottser » Unassigned
Status: Active » Needs review
FileSize
1.37 KB
Cottser’s picture

Issue summary: View changes
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Its part of the twig 2.x update, so totally fine, even if for now, nothing actually pass the boolean along.

xjm’s picture

Issue tags: -rc target triage +rc target

Discussed with @alexpott, @effulgentsia, and @catch and we agreed with this being an rc target.

xjm’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • xjm committed f0bd339 on 8.0.x
    Issue #2600152 by Cottser, dawehner: Make ThemeRegistryLoader only throw...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.