Support new fandangled PHP array syntax

Yay, thanks! While the patch also parses array(.... ] and [....), those should hopefully not appear in Drupal code. :) There are other things that break more badly with bad code.

So this is my only concern:

+++ b/potx.inc
@@ -1274,19 +1274,19 @@ function _potx_find_context($tf, $ti, $file, $function_name) {
-          if ($_potx_tokens[$ti] == ')') {
+          if (_potx_is_end_of_array($_potx_tokens[$ti])) {

@@ -1317,6 +1317,39 @@ function _potx_find_context($tf, $ti, $file, $function_name) {
+/**
+ * Determines if at the end of an array.
+ *
+ * @param string $token
+ *   The token being processed.
+ *
+ * @return bool
+ *   TRUE is  at the end of an array, FALSE if not.
+ */
+function _potx_is_end_of_array($token) {
+  return $token == ')' || $token == ']';
+}

This second use of this function is not actually meant to find end of array, it was meant to figure out the end of the arg argument which may include functions invoked, etc. For example:

t('Boo @value', array('@value' => boo_load_multiple([1])[0]->id()) (a contrived example to contain all of long arrays, short arrays and methods :)

In this case the method invocations and arrays both go down to the nesting and we are interested when we come back out at the end of the arguments short or long array part :)

Also causes issues with #2601370: [META] Parsing notices with Drupal 8 RC2, adding as parent.

More test coverage with unique strings for different combinations of tokens and inlining the end of nesting check where it does not necessarily mean end of array. The test includes function calls, nested arrays, etc. to demonstrate that now :)

I did not apply @alexpott's patch proper. Now with the rename of module to module.txt.

Test was failing because it asserted a source string we did not have in the test anymore :) Adding one more test for a complicated options array and some docs.

All right, got this one in. Will see if this resolves the outstanding ones from #2601370: [META] Parsing notices with Drupal 8 RC2 :)