Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File : core/modules/field/field.module

I found there is one unused variable $field_ui_url in field_help(). These can be replaceable.

CommentFileSizeAuthor
#2 2598300-1.patch3.63 KBkrknth

Comments

krknth created an issue. See original summary.

krknth’s picture

krknth commented
Assigned: krknth » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2598300-1.patch3.63 KB

patch attached

krknth’s picture

krknth commented
Issue tags: +Novice
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Looks good, the second replacement might even be more major than the fact that the variable is unused, since it doesn't check if help is enabled.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2598300-1.patch, failed testing.

krknth’s picture

krknth commented
Status: Needs work » Reviewed & tested by the community

Restarted test & it passing.
Moving to old state RTBC as it moved by BOT

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Improve field_help() by replacing unused variable $field_ui_url » Improve field_help() by actually using $field_ui_url

  • alexpott committed 8c9a75a on 8.1.x 
    Issue #2598300 by krknth: Improve field_help() by actually using $...

  • alexpott committed 7fd7445 on 
    Issue #2598300 by krknth: Improve field_help() by actually using $...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I agree with #4 the second replacement is more important. Based on @xjm's post release triage document, committed 7fd7445 and pushed to 8.0.x and 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.