Problem/Motivation

Currently the loop plugin RulesLoop doesn't seem to take in account that it might loops over a something, e.g. a translatable field with multiple items, that's translatable.
Thus it always requests LANGUAGE_NONE instead using the current language.
Which means for entity translation that always the "fallback" language is taken if it's enabled / available.

Proposed resolution

To avoid backward compatibility issues we could introduce a new configuration flag to tell a loop if it should act translation / language aware.
To keep the configuration backward compatible the new option has to be optional.

Remaining tasks

Reviews needed.

User interface changes

New option in RulesLoop configuration form.

API changes

Data model changes

CommentFileSizeAuthor
#2 rules-loop-not-language-aware-2597291-1.patch1.61 KBdas-peter

Comments

das-peter created an issue. See original summary.

das-peter’s picture

das-peter commented
Title: Loop Plugin doesn't handle translations » RulesLoop plugin doesn't handle translations / language specific lists
Issue summary: View changes
StatusFileSize
new rules-loop-not-language-aware-2597291-1.patch1.61 KB

First shot at the problem.

Status: Needs review » Needs work

The last submitted patch, 2: rules-loop-not-language-aware-2597291-1.patch, failed testing.

Status: Needs work » Needs review

das-peter queued 2: rules-loop-not-language-aware-2597291-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: rules-loop-not-language-aware-2597291-1.patch, failed testing.