Imagecache has been updated to version 2 and now comes with a new set of API functions. In it's current state jlightbox will throw an error if imagecache 2 is installed. I've attached a patch to fix this problem.

Please test and let me know if it works for you. Thanks.

CommentFileSizeAuthor
#2 jlightbox-imagecache2standards.patch1.51 KBtanc
jlightbox-imagecache2.patch2.5 KBtanc

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

Sorry, but this patch does not adhere to http://drupal.org/coding-standards

It would be great if you could correct the coding-style, indentation, braces after if statements, aso.

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
StatusFileSize
new jlightbox-imagecache2standards.patch1.51 KB

Hi sun, I've corrected the patch to the best of my knowledge. I'm new to the Drupal standards so if there is anything I've done wrong would you point it out to me and tell me the correct way so I learn for next time? I'd really appreciate it, thanks.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

Thanks, it looks great now. (albeit you could have created the patch against latest code in CVS, instead of a potentially outdated working copy - see http://drupal.org/patch/create for further information)

Needs testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Imagecache 2 API and jlightbox issue » Update for ImageCache 2 API
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.