In order to develop a migration path for translated content, we need some actual, y'know, translated content in Migrate Drupal's database fixtures. :) This should be its own patch because enabling the relevant modules adds a great deal of data to the fixtures, and I don't want to mix that up with patches that contain actual migration logic.
Tagging for RC target triage because this only affects Migrate Drupal -- and only its tests at that.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2594263-8.patch | 771.49 KB | phenaproxima |
| #7 | 2594263-7.patch | 762.45 KB | phenaproxima |
| #2 | 2594263-2.patch | 753.86 KB | phenaproxima |
Comments
Comment #2
phenaproximaHere we go. This patch changes the fixtures thusly:
Drupal 6
Drupal 7
Comment #3
neclimduleep, that's a bit disruptive for the couple migrate patches in the queue changing the fixture. But yeah, this is something we should probably do.
Comment #4
phenaproximaThey can go first. These changes are easy to re-roll.
Comment #6
gábor hojtsyMy understanding is this is broken out of and apparently somewhat an extension of #2225775: Migrate Drupal 6 core node translation to Drupal 8.
Comment #7
phenaproximaSo it looks like running database updates changed values which the tests were depending on, and that's why all those failures happened. I have changed the tests (and, in one case, a migration) accordingly.
A couple of tests for the Drupal 7 Aggregator migration path were majorly changed, since aggregator feeds are very dynamic by nature and can change any time the fixtures are updated normally.
I had to change a migration test or two in the Comment module, because the fixture updates altered certain comment-related variables.
Comment #8
phenaproxima@Kazanir pointed out that one of the modified assertions MigrateCommentVariableInstanceTest was sketchy -- it was asserting something that should not have been changed in the Drupal 6 database fixture. Fixed that. Here's to not re-rolling this monster again.
Comment #9
Kazanir commentedLooks good now :thumbsup:
Comment #11
webchickOk, went through this patch, apart from the dump file exports (though I did scan them and yikes, Locale is a monster ;)). Some nice bug fixes in here, as well as i18n coverage for test data, yay!
This code is all confined to Migrate stuff, which is an experimental module, which I believe makes it RC eligible. It's also just test stuff, so doubly-eligible. Tagging.
Committed and pushed to 8.0.x. Thanks!