Problem/Motivation

Follow-up to #2584837: Double translation in template_preprocess_field_multiple_value_form()

Remove nested 'title' render array because that's two render arrays that we don't need.

    $header = array(
      array(
        'data' => array(
          '#prefix' => '<h4 class="label">',
          'title' => array(
            '#markup' => $element['#title'],
          ),
          '#suffix' => '</h4>',
        ),
        'colspan' => 2,
        'class' => array('field-label'),
      ),

Proposed resolution

Bring it down to one render array.

Remaining tasks

Ensure this still works through manual testing.

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

Status: Active » Needs review
FileSize
546 bytes
joelpittet’s picture

Issue summary: View changes

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

Issue summary: View changes
Issue tags: +Novice, +Needs manual testing
joelpittet’s picture

Issue tags: +Dublin2016
jordana’s picture

I'll take a look at this

aburrows’s picture

null

jordana’s picture

@protitude basically mentored me in helping me test this.
We're both first time contributors and are at Drupalcon Dublin

We tested the patch and it works well - no visual change before and after.
Checked rendered markup and all looks good.

Attached screenshots -
Before: 2016-09-30_08-42-10.png
Before Patch
After: 2016-09-30_08-43-20.png
After Patch

aburrows’s picture

Status: Needs review » Reviewed & tested by the community

@jordana has shown this to me and there are no differences, screenshots have been taken for consistancy for the issue.
RTBC++

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 29a02cb and pushed to 8.3.x. Thanks!

  • alexpott committed 29a02cb on 8.3.x
    Issue #2592025 by joelpittet, jordana:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.