Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 Oct 2015 at 18:12 UTC
Updated:
8 Nov 2015 at 20:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
berdirComment #3
Jaesin commentedI just wrote basically the same patch:
Comment #4
lendudeStill needs tests, so back to needs work.
Comment #5
berdirLets add them, then.
Trivial fix with test coverage that really shouldn't break anything, so maybe we can get it in before 8.0.0?
Comment #6
berdirWeird double post is weird
Comment #8
Jaesin commentedThe easiest to test this is to create a view with two "nid" contextual filters and a path like: "test-view/%/%". Maybe disable caching for the view for good measure.
Add a "No results behavior" of "Global: Text area" with the following content:
You will notice that if you go to the url: "test-view/12345/54321" without the corresponding nodes existing, you will get an output like:
After applying the patch in #6 , you should see:
as expected.
Comment #9
xjmAdding the RC target reasoning to the summary.
Comment #11
tim.plunkettWent to RTBC this, see I'm behind the times. +1 from me :)
Comment #12
effulgentsia commentedI discussed this with @xjm, and we agreed that "tokens are broken in Views" qualifies as sufficiently high impact and that the patch qualifies as sufficiently low disruption, so it's good as an RC target per https://www.drupal.org/core/d8-allowed-changes#rc.
Comment #14
xjmCommitted and pushed to 8.0.x. Thanks for the fix! Thanks also @Jaesin for the excellent testing steps.