The core of Drupal 8 has a composer.json itself, which defines the necessary dependencies to it. However, the way that file core/includes/bootstrap.inc is defined causes the core becomes extremely attached to a predefined structure of the directories sites/modules/themes.

At line 134 of the file core/includes/bootstrap.inc has:
define('DRUPAL_ROOT', dirname(dirname(__DIR__)));

Note that this does not give freedom to the developer to change the location of the directories sites/modules/themes. In this way only can use the core through the drupal/drupal package. Thus, it is not possible to have the drupal/core as dependence on any project other than the drupal/drupal, since it would be necessary to have the directories sites/modules/themes, as well as the front controllers, within the vendor directory of our application, which is unthinkable.

Simply change this line of code to:

if (!defined('DRUPAL_ROOT'))
    define('DRUPAL_ROOT', dirname(dirname(__DIR__)));

allow the developer to have control of the directory structure, and make drupal/core more decoupled and reusable.

Comments

lainosantos created an issue. See original summary.

lainosantos’s picture

lainosantos commented
Category: Feature request » Bug report
lainosantos’s picture

lainosantos commented

There is many files that use the constant DRUPAL_ROOT. I think that it will require more refactor. :(

dawehner’s picture

dawehner
Primary language German
commented

There is many files that use the constant DRUPAL_ROOT. I think that it will require more refactor. :(

Using is not the problem right, its more about defining it ..., but yeah ideally DRUPAL_ROOT would be site by the front controller. Note: We also have
\Drupal\Core\DrupalKernel::getAppRoot which is the same thing but right

lainosantos’s picture

lainosantos commented

You're right, dawehner.

I said about refactoring, because I realized that it not only uses the constant to refer the directories sites/themes/modules, but also use it to refer the core itself. As, for example, \Drupal\Core\Session\SessionHandler::write():

require_once DRUPAL_ROOT. '/core/includes/errors.inc';

This confirms that there is a strong coupling between the drupal/core and drupal/drupal packages. Also among the directory structure, with no need.

Also have you talked about: \Drupal\Core\DrupalKernelInterface::getAppRoot().

lainosantos’s picture

lainosantos commented
Component: bootstrap system » base system
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Title: Decoupling drupal/core from predefined directory structure » [meta] Decoupling drupal/core from predefined directory structure
Version: 8.0.0-rc1 » 8.1.x-dev
Category: Bug report » Plan

+1.

We should work on decoupling everything. :-)

lainosantos’s picture

lainosantos commented

+1

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Added this as a child issue, but never mentioned it here: #2631362: Inject DRUPAL_ROOT into DrupalKernel

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

joachim’s picture

joachim commented
Issue tags: +Needs issue summary update

Needs an issue summary update if this is a meta.

And how does this relate to #2385395: Make Drupal core folder agnostic and allow it to be placed in vendor/drupal/core and #1672986: Option to have all php files outside of web root.?

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.