Problem/Motivation

Some use statements became unused from #2072945: Remove the $langcode parameter in EntityAccessControllerInterface::access() and friends

#2533800: Remove all unused use statements from core went in, so let's tidy these up also.

Proposed resolution

Remove the unused use statements.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 2584297-4.patch2.73 KBYesCT
#4 interdiff.2584297.2.4.txt449 bytesYesCT
#2 2584297-2.patch2.29 KBYesCT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT created an issue. See original summary.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Assigned: YesCT » Unassigned
Status: Active » Needs review
FileSize
2584297-2.patch2.29 KB
YesCT’s picture

YesCT CreditAttribution: YesCT commented

trying to get phpstorm code inspection to tell me what all the unused use statements are... and not finding the correct command.

[edit]
tim helped

shift shift
run inspection by name
(cmd-shift-a)

unused import
(option-shift-cmd-i)

YesCT’s picture

YesCT CreditAttribution: YesCT commented
FileSize
interdiff.2584297.2.4.txt449 bytes
2584297-4.patch2.73 KB

inspection shows these are all now.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks! PHPStorm reports no other unused imports.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

This rc eligible because the removal of unused use statements is an RC target. Committed 70d81c5 and pushed to 8.0.x. Thanks!

  • alexpott committed 70d81c5 on 8.0.x 
    Issue #2584297 by YesCT: Remove unused use statements (that mostly came...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.