I have the same need as in #2060861: Display total count on the title? but cannot use the "Global: Result summary" because I also want to use tokens for the Contextual filters, which do not work there.

Steps to reproduce

  • Create a view
  • Add a contextual filter
  • Set the title to "@total Results for '%1'"
  • Add a "Global: Result summary" to the Header of the view and put "@total Results for '%1'"

Expected result

Both the title and the "Global: Result summary" should replace both tokens.

  • @total with the number of results
  • %1 with the contextual filter

Actual result

  • The title replaces the %1 with your contextual, but @total is not replaced.
  • The "Global: Result summary" replaces the @total but not the %1
CommentFileSizeAuthor
#7 views-allow_summary_tokens_in-2583979-7.patch4.54 KBnwom
#6 views-allow_summary_tokens_in-2583979-6.patch4.35 KBAlexey.Samsonov
#5 views-allow_summary_tokens_in-2583979-5.patch4.23 KBocastle
#4 views-allow_summary_tokens_in-2583979-4.patch5.44 KBmrsad
#2 views-allow_summary_tokens_in-2583979-2.patch5.93 KBjojonaloha

Comments

jojonaloha created an issue. See original summary.

jojonaloha’s picture

jojonaloha commented
Status: Active » Needs review
StatusFileSize
new views-allow_summary_tokens_in-2583979-2.patch5.93 KB

The attached patch moves the "Global: Result summary" tokens to views_plugin_style, handling them with the rest of the tokens in tokenize_value(). In order to remove duplicate code, I removed this from views_handler_area_result, which is almost unneeded now. In order to not break existing views though, I made it extend views_handler_area_text since that already calls the style plugins tokenize_value() method, and set the defaults for views_handler_area_result to turn on tokens, which are required now for the summary to work.

nwom’s picture

nwom commented

I tested this against an older stable version and it worked amazingly. I added @total to the title without problems. Thank you very much!

mrsad’s picture

mrsad commented
StatusFileSize
new views-allow_summary_tokens_in-2583979-4.patch5.44 KB

Updated patch to latest 7.x-3.x-dev.

ocastle’s picture

ocastle commented
StatusFileSize
new views-allow_summary_tokens_in-2583979-5.patch4.23 KB

Patch #4 works well for the title.

However changing the extended class to views_handler_area_text causes the 'Global: Result Summary' field to use text_format instead of textarea. This might cause HTML to be stripped from the output until the field format is updated.

I don't think this is ideal when trying to support existing views. I've attached a new patch using the original code but just adjusting to run it though token replacement.

Alexey.Samsonov’s picture

Alexey.Samsonov commented
StatusFileSize
new views-allow_summary_tokens_in-2583979-6.patch4.35 KB

Adapted for latest 3.x-dev

nwom’s picture

nwom commented
StatusFileSize
new views-allow_summary_tokens_in-2583979-7.patch4.54 KB

#6 no longer applied to the latest dev or stable. Here is a re-roll against the newest dev.