Hi all

I have download and managed to get things working with this module, works exactly as when we had things running inside Feeds, easy transition :)

Just one issue for me. When editing the Mappings in the UI for my 'Entity Processor' the mapping fields are showing up in the dropdown, though when I select them, it says they are missing.

The thing is, everything still works and maps the data to my fields correctly. So things still work, though looking at it, it says 'Missing'. Maybe this is a small visual error.

See attached images for example.

Thnaks, Barry

CommentFileSizeAuthor
#6 Screen-shot-2015-10-10-at-15.12.38.png10.08 KBcomputerbarry
#3 feeds_entity_processor-hook-targets-2581911-3.patch605 bytesmegachriz
#2 Screen-shot-2015-10-07-at-15.46.04.png5.74 KBcomputerbarry
Screen-shot-2015-10-07-at-15.14.22.png6.3 KBcomputerbarry
Screen-shot-2015-10-07-at-15.13.48.png15.49 KBcomputerbarry

Comments

computerbarry created an issue. See original summary.

computerbarry’s picture

computerbarry commented
StatusFileSize
new Screen-shot-2015-10-07-at-15.46.04.png5.74 KB

For the record, the default Title does show, it's only my Entity bundles fields that don't.

See attached. Thanks.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new feeds_entity_processor-hook-targets-2581911-3.patch605 bytes

I noticed this too a few days ago. It is caused by a combination of changes in these two issues:

I opened an issue in Feeds to extend the clever solution so the right hooks are also invoked when looking up mapping targets a second time: #2584157: Missing mapping targets in the UI for contrib processors

And here is a patch to let the Feeds entity processor to invoke hook_feeds_processor_targets() itself which should solve the problem for itself. (The other issue is made for processors that haven't adapted yet.)

computerbarry’s picture

computerbarry commented

Good catch :)
I've just added the patch, all mappings are now showing, works good MegaChriz, thanks for the patch and update.

Will report anymore issues, also keep an eye on the feeds issue.

Just wondering if, and when will this patch be added to the module itself for download?

Cheers, Barry

megachriz’s picture

megachriz
Primary language Dutch
commented

As soon I have time to commit it. Thanks for reporting back that the patch worked for you.

computerbarry’s picture

computerbarry commented
StatusFileSize
new Screen-shot-2015-10-10-at-15.12.38.png10.08 KB

Cool :)
See attached for confirmation.

Just to confirm, after adding the patch:

  • Mappings updated automatically when I viewed the mappings tab ui
  • Fresh import with new events, everything imported and updated ok

Cheers, Barry

One question MegaChriz, with all the buzz around Drupal 8 lifting off:
Where does that leave us if we want this same functionality with D8? Or it will be sometime before we can do this?

  • MegaChriz committed 3af701d on 7.x-1.x 
    Issue #2581911 by MegaChriz: fixed use FeedsProcessor::getHookTargets().
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #3.

@computerbarry
Unfortunately, a D8 version of this functionality seems to be lightyears away. At the moment I'm still focussing on the D7 version of Feeds, which I hope to bring to a stable release someday. As soon as that is done I can shift my focus to the D8 version of Feeds, for which first a UI revamp is planned (see #2443471: Implement configurable parsers.). Given that I can only spend a few hours a week on Feeds, I would need help from other developers in the community to accomplish that.

If you would like to help, you could help a lot with answering support requests in the Feeds issue queue and in trying to reproduce bugs that others reported. Would you like to do that? I know we are all busy of course, so feel free to say no. It's so easy to get too much work on your plate. I need to take care of that too, so in that light I would say no D8 version of this module in the nearby future.

computerbarry’s picture

computerbarry commented

Unfortunately, a D8 version of this functionality seems to be lightyears away.

In a way, that's good to know, I don't have to learn D8 just yet :)

If you would like to help, you could help a lot with answering support requests in the Feeds issue queue and in trying to reproduce bugs that others reported. Would you like to do that?

I feel quite privileged for you to ask me MegaChriz, I wish I could help, though I think I'd cause more problems than solutions :(

My PHP coding skills are very basic/limited and after looking of the issue list, truthly, I have no idea how to fix most. I will keep an eye on things, if I see any I can help with, by all means I will help out.

Thanks, Barry

megachriz’s picture

megachriz
Primary language Dutch
commented

@computerbarry
You don't necessary need to have PHP skills if you would like to help. You don't even need to know how to fix issues to help. For example, when someone reports a bug, but with limited info to reproduce it, you could already help a lot by trying to reproduce the bug and if you succeed to do so, provide the steps to reproduce it, so someone who can fix it have to spend less time figuring out what the bug is about (and if it is really a bug or just a configuration error).
A good guide to start is the Bug Squad guide that is used for Views (note that "Start at the back of queue" is less useful to apply to the Feeds issue queue as the oldest issues are more than 4 years old and therefore less likely to be still relevant).
Again, don't feel compulsory to do this. Only if you would like to help and have time to do so. Because before you know it, suddenly all your free time is swallowed by this project (which sort of happens to me from time to time).

computerbarry’s picture

computerbarry commented

Again, don't feel compulsory to do this. Only if you would like to help and have time to do so. Because before you know it, suddenly all your free time is swallowed by this project (which sort of happens to me from time to time).

Cool, thanks for that MegaChriz, was feeling a little bad if I don't help :)

Barry

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.