Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
language system
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Oct 2015 at 14:18 UTC
Updated:
17 Nov 2015 at 11:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
yesct commented"For most functions (see exceptions below), summary lines must start with a third person singular present tense verb"
https://www.drupal.org/node/1354#functions
"All methods and properties of classes must specify their visibility: public, protected, or private."
https://www.drupal.org/node/608152#visibility
"Lines containing comments (including docblocks) must wrap as close to 80 characters as possible without going over..."
https://www.drupal.org/node/1354#drupal
Comment #4
yesct commentedI dont believe the old testbot.
and should probably think if this would be allowed in https://www.drupal.org/core/d8-allowed-changes
Comment #6
tstoecklerLooks good to me. This is docs only so should be permitted anytime, no?!
Edit: Oh, and thanks, good find!
Comment #7
wim leersThe current issue title was very misleading: it made me think this was fixing something with language switch links.
Comment #8
wim leersAnd because this only touches docs, this is RC eligible.
Comment #9
alexpottCommitted 6efce42 and pushed to 8.0.x. Thanks!