Problem/Motivation

Follow-up to #2505263: Session language switch links are (sometimes) broken

Some comments wrapped wrong, comment third person thing.

Proposed resolution

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
#2 2581817.1.patch3.06 KByesct

Comments

YesCT created an issue. See original summary.

yesct’s picture

Title: Clean up to Session language switch links are (sometimes) broken » Clean up to: Session language switch links are (sometimes) broken
Status: Active » Needs review
StatusFileSize
new3.06 KB

"For most functions (see exceptions below), summary lines must start with a third person singular present tense verb"
https://www.drupal.org/node/1354#functions

"All methods and properties of classes must specify their visibility: public, protected, or private."
https://www.drupal.org/node/608152#visibility

"Lines containing comments (including docblocks) must wrap as close to 80 characters as possible without going over..."
https://www.drupal.org/node/1354#drupal

Status: Needs review » Needs work

The last submitted patch, 2: 2581817.1.patch, failed testing.

yesct’s picture

Status: Needs work » Needs review

I dont believe the old testbot.

and should probably think if this would be allowed in https://www.drupal.org/core/d8-allowed-changes

tstoeckler queued 2: 2581817.1.patch for re-testing.

tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me. This is docs only so should be permitted anytime, no?!

Edit: Oh, and thanks, good find!

wim leers’s picture

Title: Clean up to: Session language switch links are (sometimes) broken » Follow-up for #2505263: clean up comments

The current issue title was very misleading: it made me think this was fixing something with language switch links.

wim leers’s picture

Issue tags: +rc eligible

And because this only touches docs, this is RC eligible.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 6efce42 and pushed to 8.0.x. Thanks!

  • alexpott committed 6efce42 on 8.0.x
    Issue #2581817 by YesCT: Follow-up for #2505263: clean up comments
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.