UpdatePostUpdateTest is extremely fragile to change and does not test batches in post updates

For this particular issue I think it is enough to switch form assert Equal to a checking that at least these 5 update functions are in the state.

Perfect!

THANK YOU

+++ b/core/modules/system/src/Tests/Update/UpdatePostUpdateTest.php
@@ -49,24 +51,34 @@ public function testPostUpdate() {
-    $updates = array_merge([
-      'block_post_update_disable_blocks_with_missing_contexts',
-      'field_post_update_save_custom_storage_property',
-      'field_post_update_entity_reference_handler_setting',
-      'system_post_update_recalculate_configuration_entity_dependencies',
-      'views_post_update_update_cacheability_metadata',
-    ], $updates);

Hallelujah! I'd use emojis, but Drupal 7 doesn't support that, so using ASCII instead: kill it with fire!

This only changes a test, so tagging "rc eligible" per https://www.drupal.org/core/d8-allowed-changes#rc.

Pushed to 8.0.x.

Looks like this broke PHP 7:

https://www.drupal.org/pift-ci-job/56619

Sending revert for a test run.

There are certainly tests failing which are unrelated with updates in general, it could be just "random" PHP7 failures.

Yeah it's not a regression introduced here anyway: https://www.drupal.org/pift-ci-job/57019 Apologies for the false alarm.

fail: [Other] Line 59 of core/modules/system/src/Tests/Update/UpdatePostUpdateTest.php:
Value array (
  0 => 'update_test_postupdate_post_update_first',
  1 => 'update_test_postupdate_post_update_second',
  2 => 'update_test_postupdate_post_update_test1',
  3 => 'update_test_postupdate_post_update_test0',
) is identical to value array (
  0 => 'update_test_postupdate_post_update_test0',
  1 => 'update_test_postupdate_post_update_test1',
  2 => 'update_test_postupdate_post_update_second',
  3 => 'update_test_postupdate_post_update_first',
).

fail: [Other] Line 69 of core/modules/system/src/Tests/Update/UpdatePostUpdateTest.php:
Value array (
  0 => 'block_post_update_disable_blocks_with_missing_contexts',
  1 => 'field_post_update_save_custom_storage_property',
  2 => 'field_post_update_entity_reference_handler_setting',
  3 => 'system_post_update_recalculate_configuration_entity_dependencies',
  4 => 'views_post_update_update_cacheability_metadata',
  5 => 'update_test_postupdate_post_update_first',
  6 => 'update_test_postupdate_post_update_second',
  7 => 'update_test_postupdate_post_update_test1',
  8 => 'update_test_postupdate_post_update_test0',
) is equal to value array (
  0 => 'block_post_update_disable_blocks_with_missing_contexts',
  1 => 'field_post_update_entity_reference_handler_setting',
  2 => 'field_post_update_save_custom_storage_property',
  3 => 'system_post_update_recalculate_configuration_entity_dependencies',
  4 => 'views_post_update_update_cacheability_metadata',
  5 => 'update_test_postupdate_post_update_test0',
  6 => 'update_test_postupdate_post_update_test1',
  7 => 'update_test_postupdate_post_update_second',
  8 => 'update_test_postupdate_post_update_first',
).