views.style.table schema has incorrect label for 'description'

We don't say "Table caption" either. Is "Table description" the UI text used on the admin UI for this field? We usually try to match that because then people can match the things together AND the translations would also be the same (easy!)

maybe here... I'm not sure yet.

yeah, when I put in values, then I can see.

I think this makes those match the UI. (didn't check *everything* in this UI)

which makes the translate form (after a drush cr) look like

Yay, looks good!

Test fails were entirely unrelated.

Several questions to figure out what of this, if any, can go into a patch release:

• Do these labels themselves get translated? I.e. would this break the text for translators who are translating?
• Or would it break existing config translations?
• Is this something that gets stored in config and would require an upgrade path?
• Why is there (empty) and blank fields in the before description, but table names in the after descruption? Is that also caused by this patch somehow, or were the screenshots just produced slightly differently?

The third option, with the duplicated "Caption", is obviously just plain wrong. However, now that 8.0.0 is released, we should possibly separate the improvements for the other two strings and have those go into 8.1.x instead, to reduce the disruption for translations. References: https://www.drupal.org/core/d8-allowed-changes#minor and https://www.drupal.org/core/d8-bc-policy

@Gábor Hojtsy, thoughts?

@xjm: yes, they are displayed in the core config translation UI, as screenshot in the summary; yes they would change translatable strings, but these are minor (and the original ones don't make sense, the changing strings are not a reason to keep the UI that does not make sense).

On the other hand this will not break existing configuration and is not something stored in configuration, and will not need an upgrade path. The strings are merely used to display the config translation UI (in core). They are not stored anywhere.

As for which changes to put into which versions, the "new" strings are already used in views, in fact the views schema should have just used the same strings as the views UI, which in fact means LESS work for translators:

$ git grep "Caption for the table"
core/modules/views/src/Plugin/views/style/Table.php:      '#title' => $this->t('Caption for the table'),
$ git grep "Summary title"
core/modules/views/src/Plugin/views/style/Table.php:      '#title' => $this->t('Summary title'),
$ git grep "Table description"
core/modules/views/src/Plugin/views/style/Table.php:      '#title' => $this->t('Table description'),

In short, this patch removes a few incorrect strings and replaces them with strings that are already in core (and already translated), so while it is no work for translators, it also improves the translation user interface without needing an upgrade path. That sounds like win-win-win.

Thanks @Gábor Hojtsy! Based on that it also sounds to me like it will be good to include this fix in a patch release.

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!