Problem/Motivation

The hook_help for Views UI module still says:

Theming views.
The template files used by views can be overridden from a custom theme. When editing a view, you can see the templates that are used and alternatives for overriding them by clicking on the "Templates" link, found in the Advanced > Other section under "Output".

This functionality has been removed. The hook_help needs this removed as well.

Proposed resolution

Remove the help about feature that was removed.

Remaining tasks

Make patch.

User interface changes

Remove outdated help.

API changes

No.

Data model changes

No.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because Help is incorrect
Issue priority Normal
Unfrozen changes Unfrozen because it only removes a UI string that is help/documentation. Since it is only removing a string, it can also be done during RC or even later.
CommentFileSizeAuthor
#4 2581195-v2.patch2.68 KBjhodgdon
#2 2581195.patch1.45 KBjhodgdon

Comments

jhodgdon created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2581195.patch1.45 KB

Here's the patch.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/views_ui/views_ui.module
@@ -29,8 +29,6 @@ function views_ui_help($route_name, RouteMatchInterface $route_match) {
       $output .= '<dt>' . t('Exporting and importing views.') . '</dt>';
       $output .= '<dd>' . t('Views can be exported and imported as configuration files by using the <a href=":config">Configuration Manager module</a>.', array(':config' => (\Drupal::moduleHandler()->moduleExists('config')) ? \Drupal::url('help.page', array('name' => 'config')) : '#')) . '</dd>';
-      $output .= '<dt>' . t('Theming views.') . '</dt>';
-      $output .= '<dd>' . t('The template files used by views can be overridden from a custom theme. When editing a view, you can see the templates that are used and alternatives for overriding them by clicking on the "Templates" link, found in the Advanced &gt; Other section under "Output".') . '</dd>';

To be honest also the exporting/importing is not really needed as part of the views UI help. For now just removing the "Themeing views" part is though fine.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
StatusFileSize
new 2581195-v2.patch2.68 KB

Also noticed that all the Uses headings end in . and they shouldn't. Here's a new patch.

I think leaving the import/export is OK because at least the functionality is provided in the UI by a different module. We have cross-references like this all over help, like Menu says you can display them with Block, etc.

But in the theme suggestions case, the new instruction would be to edit your settings.php file to turn on Twig debug or something like that, which is ... not really UI material.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: +rc deadline

Now this changes strings so is RC deadline

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

I think leaving the import/export is OK because at least the functionality is provided in the UI by a different module. We have cross-references like this all over help, like Menu says you can display them with Block, etc.

Ah okay, that is fair. Yeah I was just wondering, I mean I'm personally happy if people with support questions have an easy time finding the export UI.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

ok I need to split out the "fix the ." strings from the "remove" strings. Leaving this as the "remove" patch (the patch in #1). Ignore the patch in #4.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

other issue: #2581243: Views UI help does not have standard headings already marked related there.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: -rc deadline

Oh and this one is not "rc deadline" any more as it only removes text.

xjm’s picture

xjm
she/her
Primary language English
commented

I think this patch needs a reroll for the other one?

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Fixed

Committed and pushed #1 to 8.0.x. Thanks!

  • webchick committed 73717e4 on 8.0.x 
    Issue #2581195 by jhodgdon, dawehner: Views UI help still talks about...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.