Great module for simplifying breadcrumb settings, although I find the use of "exclude paths / core paths" to be cumbersome in the case where only a few paths should use this module.

Therefore, I propose using a single whitelist of paths instead of the current approach or even better, having the choice between the two.

CommentFileSizeAuthor
#5 breadcrumbs_by_path-whitelist_instead_of_exclude_paths-2580415-4.patch3.33 KBPascalAnimateur
#3 breadcrumbs_by_path-whitelist_instead_of_exclude_paths-2580415-3.patch3.33 KBPascalAnimateur
#2 breadcrumbs_by_path-whitelist_instead_of_exclude_paths-2580415-2.patch2.49 KBPascalAnimateur

Comments

PascalAnimateur created an issue. See original summary.

PascalAnimateur’s picture

PascalAnimateur commented
Status: Active » Needs review
StatusFileSize
new breadcrumbs_by_path-whitelist_instead_of_exclude_paths-2580415-2.patch2.49 KB

Here's a patch to use a whitelist instead of exclude paths. Could be improved to offer the choice of behaviour.

PascalAnimateur’s picture

PascalAnimateur commented
StatusFileSize
new breadcrumbs_by_path-whitelist_instead_of_exclude_paths-2580415-3.patch3.33 KB

There's a related problem with this module preventing other breadcrumb modules (menu_breadcrumb in my case) from setting the trail.

Here's a revised patch that fixes that by not setting an empty trail for paths not in the whitelist.

Status: Needs review » Needs work

The last submitted patch, 3: breadcrumbs_by_path-whitelist_instead_of_exclude_paths-2580415-3.patch, failed testing.

PascalAnimateur’s picture

PascalAnimateur commented
Status: Needs work » Needs review
StatusFileSize
new breadcrumbs_by_path-whitelist_instead_of_exclude_paths-2580415-4.patch3.33 KB

Ignore previous patch...

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented