Problem/Motivation

#2497667: Add libraries-extend to themes' *.info.yml introduced libraries-extend. Which means we can now get rid of all the complexity in classy_library_info_alter() and use the much simpler, fully declarative libraries-extend. This then also sets the right example for contrib themes

There even already is a @todo for this.

Proposed resolution

Use libraries-extend.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 interdiff.txt2.19 KBwim leers
#3 classy_seven_libraries-extend_2580255-3.patch3.82 KBwim leers
#2 classy_libraries-extend_2580255-2.patch1.68 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new classy_libraries-extend_2580255-2.patch1.68 KB

I manually tested this and it works fine, but it would ideally be approved by someone very familiar with Classy.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove classy_library_info_alter() in favor of libraries-extend » Remove (classy|seven)_library_info_alter() in favor of libraries-extend
Component: Classy theme » Seven theme
StatusFileSize
new classy_seven_libraries-extend_2580255-3.patch3.82 KB
new interdiff.txt2.19 KB

While at it, I figured we might as well do the same for Seven as well. Then This then also sets the right example for contrib themes is completely true.

fabianx’s picture

fabianx commented
Assigned: Unassigned » lewisnyman
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs subsystem maintainer review

RTBC - looks great to me, assigning to LewisNyman for sign-off on seven changes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Assigned: lewisnyman » Unassigned
Status: Reviewed & tested by the community » Fixed

I think it is great that the core themes use libraries-override and libraries-extend and show other themes the way to go. Committed 2d1f427 and pushed to 8.0.x. Thanks!

  • alexpott committed 2d1f427 on 8.0.x 
    Issue #2580255 by Wim Leers: Remove (classy|seven)_library_info_alter()...
lewisnyman’s picture

lewisnyman
he/him
commented

I confirm that the files are being loaded correctly. RTBC++

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: -Needs subsystem maintainer review

Whew, thanks Lewis :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.