Problem/Motivation

Add the list tag: \Drupal\Core\Entity\EntityType::getListCacheTags in \Drupal\Core\Entity\EntityListBuilder::render

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 TEST-ONLY-SHOULD-FAIL_entitylistbuilder-2579887-4.patch759 bytesstrykaizer
#4 entitylistbuilder-2579887-4.patch1.34 KBstrykaizer
#2 entitylistbuilder-2579887-2.patch615 byteshussainweb

Comments

dawehner created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new entitylistbuilder-2579887-2.patch615 bytes

This is simple enough. Let's see if something breaks in the tests.

fabianx’s picture

fabianx commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Nice! Now just need some test coverage.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new entitylistbuilder-2579887-4.patch1.34 KB
new TEST-ONLY-SHOULD-FAIL_entitylistbuilder-2579887-4.patch759 bytes

Test added

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Nice work!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: TEST-ONLY-SHOULD-FAIL_entitylistbuilder-2579887-4.patch, failed testing.

The last submitted patch, 4: TEST-ONLY-SHOULD-FAIL_entitylistbuilder-2579887-4.patch, failed testing.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs work » Reviewed & tested by the community

Setting back to rtbc (test should fail)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Very nice!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 9bd9390 on 8.0.x 
    Issue #2579887 by StryKaizer, hussainweb, dawehner: EntityListBuilder...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.